In message <E145WRS-0008A3-00@the-village.bc.nu> you write:
> > since test11, the NFS code uses the set_bit and related routines
> > to manipulate the wb_flags member of the nfs_page struct (nfs_page.h).
> > Unfortunately, wb_flags has still data type 'int'.
>
> NFS is wrong. Rusty did a complete audit of the code and I've been feeding
> some stuff to Linus. That one may have been missed
Yes, didn't grep the headers. Hmm... that's the only one in
include/linux/*.h though.
> > What do you suggest we should do? Fix nfs_page to use a 'long'
> > variable, or change our bitops macros to use ints?
>
> Fix NFS
Yep, it's trivial.
Cheers,
Rusty.
-- Hacking time.--- working-2.4.0-test12/include/linux/nfs_page.h.~1~ Thu Dec 14 14:20:28 2000 +++ working-2.4.0-test12/include/linux/nfs_page.h Fri Dec 15 16:46:09 2000 @@ -31,10 +31,10 @@ struct page *wb_page; /* page to read in/write out */ wait_queue_head_t wb_wait; /* wait queue */ unsigned long wb_timeout; /* when to read/write/commit */ + unsigned long wb_flags; /* long req'd for set_bit */ unsigned int wb_offset, /* Offset of read/write */ wb_bytes, /* Length of request */ - wb_count, /* reference count */ - wb_flags; + wb_count; /* reference count */ struct nfs_writeverf wb_verf; /* Commit cookie */ }; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Sat Dec 23 2000 - 21:00:18 EST