Greetings all,
Patch is against 2.2.17, drivers/net/lance.c.
I believe this to be "obviously correct," but please correct me if I'm
wrong.
This moves a reference to skb->len to before the possible
dev_kfree_skb(skb) call. Though it appears to work as is, I suspect it
is incorrect.
Please apply or let me know why.
Eli
ps. It's an attachment rather than inline because I can't seem to get
Netscape (4.71) to do that without replacing tabs with spaces. Grr.
--------------------. "To the systems programmer, users and applications
Eli Carter | serve only to provide a test load."
eli.carter@inet.com `---------------------------------- (random fortune)
--- lance.c.2.2.17 Mon Nov 13 12:13:11 2000
+++ lance.c Tue Nov 28 11:46:16 2000
@@ -926,6 +926,8 @@
lp->tx_ring[entry].misc = 0x0000;
+ lp->stats.tx_bytes += skb->len;
+
/* If any part of this buffer is >16M we must copy it to a low-memory
buffer. */
if ((u32)virt_to_bus(skb->data) + skb->len > 0x01000000) {
@@ -941,7 +943,6 @@
lp->tx_ring[entry].base = ((u32)virt_to_bus(skb->data) & 0xffffff) | 0x83000000;
}
lp->cur_tx++;
- lp->stats.tx_bytes += skb->len;
/* Trigger an immediate send poll. */
outw(0x0000, ioaddr+LANCE_ADDR);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Thu Nov 30 2000 - 21:00:20 EST