Re: [PATCH] Make agpsupport work with modversions

From: Christoph Hellwig (hch@caldera.de)
Date: Wed Oct 18 2000 - 12:14:21 EST


In article <Pine.LNX.4.10.10010180941070.7090-100000@penguin.transmeta.com> you wrote:

> However, the fact that you need that dependency on CONFIG_MODULES _still_
> shows that something is wrong. That dependency should not be there, and
> the drm code should be fixed. Why does it care about CONFIG_MODULES at
> all? It should not, and it _must_ not do that.

Because get_module_symbol() needs CONFIG_MODULES.
IMHO we should simply get rid of get_module_symbol in drm.

> I have no idea what the get_module_symbol() code in question is trying to
> do, but this should be _fixed_ and not just worked around. That's a bug.

It gets the symbol of a function, that's name is passed as char * to
get_module_symbol().

        Christoph

-- 
Always remember that you are unique.  Just like everyone else.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon Oct 23 2000 - 21:00:13 EST