Re: [PATCH] Make agpsupport work with modversions

From: Linus Torvalds (torvalds@transmeta.com)
Date: Wed Oct 18 2000 - 12:49:24 EST


On Wed, 18 Oct 2000, Christoph Hellwig wrote:

> In article <Pine.LNX.4.10.10010180941070.7090-100000@penguin.transmeta.com> you wrote:
>
> > I have no idea what the get_module_symbol() code in question is trying to
> > do, but this should be _fixed_ and not just worked around. That's a bug.
>
> It gets the symbol of a function, that's name is passed as char * to
> get_module_symbol().

Oh, I know what get_module_symbol() does - I just don't understand why drm
would want to use it. There are basically no good uses for it, as far as
I'm concerned.

I assume it's something about allowing modules to be loaded in the wrong
order. Some other drivers did hooks like this in times past. The right
solution was then, and is almost certainly now, to just remove the code in
question and force the correct load order.

Rik? Can this code just go away?

                Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon Oct 23 2000 - 21:00:13 EST