Re: genhd.c?

From: Cesar Eduardo Barros (cesarb@nitnet.com.br)
Date: Sat Aug 26 2000 - 17:46:46 EST


On Sat, Aug 26, 2000 at 11:13:34PM +0100, Russell King wrote:
> Cesar Eduardo Barros writes:
> > This clearly doesn't belong into drivers/block! And genhd.c is a completely
> > misleading name for it (unless you think the comment pointing at fs/partitions
> > is the most important part of it).
>
> Yes, the comment is the most important line ;)
>
> > So I think it should be moved to init/ with a new name (init.c?), or maybe even
> > moved inside main.c (which I think would be the ideal fix).
>
> No. Definitely not. The more correct fix is to fix the drivers to use
> the new initcall stuff. Unfortunately, it seems that no one has gotten
> around to that yet, so its probably best left there for the moment.

Just because it "will be fixed in the future" means you'll leave it in the most
stupid location possible, where it'll confuse hordes of newbies and make them
think we're all crazy?

It was already bad while partition stuff was there, but now it's stupid and
only makes us look bad.

> (any volunteers?)
> _____
> |_____| ------------------------------------------------- ---+---+-
> | | Russell King rmk@arm.linux.org.uk --- ---
> | | | | http://www.arm.linux.org.uk/personal/aboutme.html / / |
> | +-+-+ --- -+-
> / | THE developer of ARM Linux |+| /|\
> / | | | --- |
> +-+-+ ------------------------------------------------- /\\\ |
>

-- 
Cesar Eduardo Barros
cesarb@nitnet.com.br
cesarb@dcc.ufrj.br
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Aug 31 2000 - 21:00:18 EST