genhd.c?

From: Cesar Eduardo Barros (cesarb@nitnet.com.br)
Date: Sat Aug 26 2000 - 15:51:23 EST

Next message: Mike Galbraith: "Re: Still haven't resolved this. INITRD/RAMSIZE detect changes in 2.4"
Previous message: Bernd Kischnick: "Re: BUG/PATCH: include/asm-*/fcntl.h"
Next in thread: Russell King: "Re: genhd.c?"
Reply: Russell King: "Re: genhd.c?"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

I recently decided to take a look at the partition code, which I could recall
being in drivers/block/genhd.c. Looking there, I had the surprise to see it had
only one function, whose beggining was:

void __init device_init(void)
{
#ifdef CONFIG_PARPORT
        parport_init();
#endif
        chr_dev_init();
        blk_dev_init();
        sti();

This clearly doesn't belong into drivers/block! And genhd.c is a completely
misleading name for it (unless you think the comment pointing at fs/partitions
is the most important part of it).

So I think it should be moved to init/ with a new name (init.c?), or maybe even
moved inside main.c (which I think would be the ideal fix).

-- 
Cesar Eduardo Barros
cesarb@nitnet.com.br
cesarb@dcc.ufrj.br
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Next message: Mike Galbraith: "Re: Still haven't resolved this. INITRD/RAMSIZE detect changes in 2.4"
Previous message: Bernd Kischnick: "Re: BUG/PATCH: include/asm-*/fcntl.h"
Next in thread: Russell King: "Re: genhd.c?"
Reply: Russell King: "Re: genhd.c?"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Thu Aug 31 2000 - 21:00:18 EST