Re: flags_t

From: Roman Zippel (
Date: Thu Aug 24 2000 - 13:15:36 EST


> Roman> If that flag ends up in a structure, it's a bug.
> Why? Most of the time you keep it locally, but still.

You have to keep locally all the time, putting it into a structure riscs
that the flags are "saved" for too long, see also the sparc restrictions
on that.

> No it ruins readability since you suddenly can no longer see what type
> of object you are actually dealing with.

So what? In this case it's absolutely unnecessary to know the type, only
save_flags/restore_flags have any business with it. It could also be
structure to possibly store some more information and the user shouldn't
care at all.

bye, Roman

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
Please read the FAQ at

This archive was generated by hypermail 2b29 : Thu Aug 31 2000 - 21:00:13 EST