Re: flags_t

From: Jes Sorensen (jes@linuxcare.com)
Date: Thu Aug 24 2000 - 12:48:28 EST


>>>>> "Roman" == Roman Zippel <zippel@fh-brandenburg.de> writes:

>> No it shouldn't, when using it in data structures you want it as
>> is as unsigned long for proper alignment of data.

Roman> If that flag ends up in a structure, it's a bug.

Why? Most of the time you keep it locally, but still.

>> Wrong, a lot of people keep thinking lets add yet another 500
>> typedef's but they don't buy you anything except complexity and
>> confusion. You can still play games directly on the original data
>> type.

Roman> What is complex about a typedef? It can increase readability,
Roman> it makes clear for what that variable has to used for and it
Roman> clearly tells that its value has to considered private.

No it ruins readability since you suddenly can no longer see what type
of object you are actually dealing with.

Jes
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Aug 31 2000 - 21:00:13 EST