Re: VFS (a_ops) change for efficient O_SYNC support?

From: Trond Myklebust (trond.myklebust@fys.uio.no)
Date: Sun May 14 2000 - 16:55:53 EST


>>>>> " " == Ulrich Kunitz <gefm21@uumail.de> writes:

> As I said the patch breaks with O_SYNC writes on NFS, so please
> don't tell me.

Which was working just fine with O_SYNC before.

Why are you trying to stuff this disk-specific code into a generic
routine? The above breakage shows precisely why this is the wrong
thing to do.

write_one_page() and waitfor_one_page() are *only* for use by things
which use the block device code in fs/buffer.c.

What is stopping you from putting the exact same code into
__block_commit_write()?

Cheers,
  Trond

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon May 15 2000 - 21:00:24 EST