Re: PATCH: rewrite of invalidate_inode_pages

From: Trond Myklebust (trond.myklebust@fys.uio.no)
Date: Fri May 12 2000 - 07:51:26 EST


>>>>> " " == Juan J Quintela <quintela@fi.udc.es> writes:

> This was a first approach patch, if people like the thing
> configurable, I can try to do that the weekend.

Juan, Linus,

   Could you please look into changing the name of
invalidate_inode_pages() to invalidate_pages_noblock() or something
like that? Since NFS is the only place where this function is used, a
change of name should not break any other code.

The reason I think this is necessary, is that this is the second time
the 2.3.x kernel is broken because somebody has misunderstood, and has
added wait_on_page() functionality to the same function.
Alternatively, please make sure that we add explicit comments to that
effect.

> Notice: that will be my first trip to /proc land....

Ugh. Sounds like an extremely complex "solution" to something which
has not yet been demonstrated to be a problem.

Cheers,
  Trond

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon May 15 2000 - 21:00:20 EST