Re: [PATCH][mount-7-1-B] fixes to pre7-1 and more mount cleanups

From: Riley Williams (
Date: Thu May 11 2000 - 03:37:56 EST

Hi Alexander.

>> Alexander, there seems to be a problem still with the
>> mntent changes in pre7-1. For example, if you create a
>> kernel thread during bootup without CLONE_FS, the
>> __copy_fs_struct will barf on the NULL
>> rootmnt/root/pwdmnt/pwd members coming from INIT_FS. I
>> actually have this happening on Sparc64 with pre7-1 which
>> is how I found the problem.

>> I think to fix this, mntget/mntput should be defined
>> analogously to dget/dput in that they just do nothing if
>> the argument is NULL.

> Umm... Yes, probably you are right. I'm a bit nervous about
> going that way right now - it will just hide some real
> places where we are getting NULL by mistake.

Asa a bare minimum, they should be defined to at least report the
fact that they received NULL to enable somebody to note that the
problem has occurred.

Best wishes from Riley.

 * Copyright (C) 2000, Memory Alpha Systems.
 * All rights and wrongs reserved.

| There is something frustrating about the quality and speed of Linux |
| development, ie., the quality is too high and the speed is too high, |
| in other words, I can implement this XXXX feature, but I bet someone |
| else has already done so and is just about to release their patch. |

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
Please read the FAQ at

This archive was generated by hypermail 2b29 : Mon May 15 2000 - 21:00:18 EST