Re: PATCH: get_module_symbol() not SMP-safe

From: Keith Owens (kaos@ocs.com.au)
Date: Tue May 09 2000 - 04:12:08 EST


On Tue, 09 May 2000 10:05:09 +0100,
David Woodhouse <dwmw2@infradead.org> wrote:
>I could actually get away with the same myself; I only call it from an init
>routine too. But even so, I think it's wrong to make that restriction on
>callers of get_module_symbol().

Callers of module services are already restricted, the module code
expects them to be holding the big kernel lock. Anybody can call
get_module_symbol() as long as they lock_kernel() first. You do not
have to be in an init_module routine. OTOH, why would anybody look for
module symbols anywhere except from init_module? You do the fixups
once, when the module is loaded.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon May 15 2000 - 21:00:13 EST