Re: PATCH: get_module_symbol() not SMP-safe

From: David Woodhouse (dwmw2@infradead.org)
Date: Tue May 09 2000 - 04:05:09 EST


kaos@ocs.com.au said:
> get_module_symbol is only called from 8390.c. AFAICT, all of the
> calls to get_module_symbol eventually trace back to init_module which
> is always called with the big kernel lock. So as long as 8390 code
> does not sleep between calling get_module_symbol and incrementing the
> module use count then there are no races.

I could actually get away with the same myself; I only call it from an init
routine too. But even so, I think it's wrong to make that restriction on
callers of get_module_symbol().

--
dwmw2

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon May 15 2000 - 21:00:13 EST