Re3: Bridge or 8139 Bug ?

From: Alfred Schweder (alf@all.de)
Date: Mon May 08 2000 - 11:39:23 EST


Hello

> On Sat, 06 May 2000, Alan Cox wrote:
> > > A ping of the IP address of the bridge is working well, but packets
> > > with the size of 1497,1498,1499 and 1500 are dropped instead of forward.
> > > If I used smaller sizes or the EEPRO ethernet cards all is working well.
> > That sounds like the 8139 driver is receiving the CRC and not removing it.
> > Then breaking when it tries to send the frame including crc back out.
> > Probably driver bug - Jeff ?
> I made some more tests. All Packets which are forwarded by the bridge
> with two 8139 are on the receiving side 4 bytes longer than on the
> sending side. When the size of the packet goes over 1500 some environments
> (kernel version and ethernet driver) drop the packets and other seems to
> strip the additional bytes and reply my ping packets also with a four
> byte to large reply packet...
Following patch (work around ?) seems to solve my problems:

*** 8139too.c~ Mon May 1 14:02:46 2000
--- 8139too.c Mon May 8 17:10:18 2000
***************
*** 1610,1616 ****
                          /* Omit the four octet CRC from the length. */
                          struct sk_buff *skb;
  
+ rx_size -= 4; /* DROP CRC */
                          skb = dev_alloc_skb (rx_size + 2);
                          if (skb == NULL) {
                                  printk (KERN_WARNING
--- 1610,1615 ----
***************
*** 1655,1661 ****
                          netif_rx (skb);
                          tp->stats.rx_bytes += rx_size;
                          tp->stats.rx_packets++;
+ rx_size += 4; /* resize for CRC */
                  }
  
                  cur_rx = (cur_rx + rx_size + 4 + 3) & ~3;
--- 1654,1659 ----

-- 
Mit freundlichen Gruessen
Dipl. Ing. A. Schweder

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon May 15 2000 - 21:00:11 EST