James,
I fail to see how this patch 'saves' any code, it does just the
opposite. The way i see it is that most drivers do NOT have any ioctls in
xxxfb_ioclt(), and this default: condition from fb_ioctl() is rarely
called anyhow. On the chance it IS called for some driver's ioctl, its
usually intended by the programmer to be specific to that driver (ie,
wouldn't be calling an ATYFB ioctl unless he knows he's on atyfb).
Therefore, the 'falling' back to the xxxfb_iotcl() is hardly ever called,
and in the case it is (which is more often then not) you're infact adding
code, not saving any.
ani
On Sun, 7 May 2000, James Simmons wrote:
>
> Hi!
>
> This patch saves on a needless function call and saves on some needless
> code duplication.
>
> Q: Why did they deprecate a.out support in linux?
> A: Because a nasty coff is bad for your elf.
>
> James Simmons [jsimmons@linux-fbdev.org] ____/|
> fbdev/gfx developer \ o.O|
> http://www.linux-fbdev.org =(_)=
> http://linuxgfx.sourceforge.net U
>
> --- fbmem.c.orig Sun May 7 12:00:28 2000
> +++ fbmem.c Sun May 7 12:01:13 2000
> @@ -418,8 +418,10 @@
> (*info->blank)(arg, info);
> return 0;
> default:
> - return fb->fb_ioctl(inode, file, cmd, arg, PROC_CONSOLE(info),
> - info);
> + if (fb->fb_ioctl)
> + return fb->fb_ioctl(inode, file, cmd, arg,
> + PROC_CONSOLE(info), info);
> + return -EINVAL;
> }
> }
>
>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Mon May 15 2000 - 21:00:10 EST