** On Apr 10, Alexander Viro scribbled:
> > down(&info_mutex);
> > card = snd_info_find_card(dentry->d_inode->i_ino);
> > if (card == NULL || card->proc_dir == NULL) {
> > up(&info_mutex);
> > return NULL;
>
> ... which is (and was) totally broken. Just what is intended here?
> And BTW, what, it's YAFS?
ALSA uses /proc/asound/ directory for publishing its information. A bit less
strange idea than /dev/sndstat...
> > }
> > strcpy(tmp, card->id);
> > up(&info_mutex);
> > return lookup_dentry(tmp, base, follow);
> > }
>
> _That_ one is easy -
> static int snd_info_card_followlink(struct dentry *dentry, struct nameidata *nd)
> {
> [same stuff, modulo the bug above]
> return vfs_follow_link(tmp, nd);
> }
To stay more in sync with the actual code, it should be:
return lookup_dentry(tmp, follow) - works, tested.
marek
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Sat Apr 15 2000 - 21:00:15 EST