Re: [patch] Space.c and -fwritable-strings

From: Nick Holloway (Nick.Holloway@alfie.demon.co.uk)
Date: Sat Apr 08 2000 - 07:32:16 EST


andrewm@uow.edu.au (Andrew Morton) writes:
> pwold011:/usr/src/linux-2.3.99-pre3/drivers/net> grep -rl '[-]>name = ' . | wc -l
> 66

That catches the 'printk( "%s\n", dev->name )' which is OK, but doesn't
catch the:

        static char devname[IFNAMSIZ];
        static struct net_device wibble { devname, ... };

> There is the inconsistent naming passed to request_region,
> identified by David Hinds (http://www.uwsg.indiana.edu/hypermail/linux/kernel/0003.3/1573.html).
> Alan says the drivers should use the "ethN" name.

The PCMCIA drivers are where I am not sure on how to proceed, and could
do with some input.

Some of the plain net drivers have a "char[N] devname" in their private
structure, which was only used to allocate space for "dev->name".
However, the PCMCIA cards use "lp->node.dev_name", but this is used in
a much wider context.

Any ideas?

-- 
 `O O'  | Nick.Holloway@alfie.demon.co.uk
// ^ \\ | http://www.alfie.demon.co.uk/

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Apr 15 2000 - 21:00:11 EST