Re: Duplicate PCI ID PCI_DEVICE_ID_VIA_82C598_0 inserted in pre2-x patches

From: Jeff Garzik (jgarzik@mandrakesoft.com)
Date: Sun Mar 19 2000 - 09:28:42 EST

Oleg Drokin wrote:
>
> Hello!
>
> Is it only me sees this duplicate PCI ID for Apollo MVP3 being
> inserted into pre2-x patches?
> --- v2.3.99-pre1/linux/drivers/ide/via82cxxx.c Tue Mar 14 19:10:39 2000
> +++ linux/drivers/ide/via82cxxx.c Thu Mar 16 14:01:05 2000
> @@ -104,6 +104,7 @@
> { "VT 82C595 Apollo VP2", PCI_DEVICE_ID_VIA_82C595, },
> { "VT 82C597 Apollo VP3", PCI_DEVICE_ID_VIA_82C597_0, },
> { "VT 82C598 Apollo MVP3", PCI_DEVICE_ID_VIA_82C598_0, },
> + { "VT 82C598 Apollo MVP3", PCI_DEVICE_ID_VIA_82C598_0, },

Although this may be a mistake, LOOK VERY CAREFULLY at surrounding code
first.

Often there are structures not visible in the patch which are dependent
on the size and order of an array such as this one.

This patch may even be a bugfix...

In any case, IMNSHO (since I wrote the probe code here) what needs to
happen is that someone needs to go through Via and other drivers, and
use the new PCI matching code, and possibly the new
pci_register_driver() interface.

        Jeff 

-- 
Jeff Garzik              | My to-do list is a function
Building 1024            | which approaches infinity.
MandrakeSoft, Inc.       |

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

This archive was generated by hypermail 2b29 : Thu Mar 23 2000 - 21:00:26 EST