Hello!
> /* It is pretty silly, SIOCSIFHWADDR exists to make this. */
>
> +/* no, it's not. IFHWADDR has to take the master down to set the hwaddr -
> + which mucks up the routing tables. This allows us to set the hwaddr
> + without ifconfig up/down the master.
> + */
dev->set_mac_address is _your_ private routine with status equal to
this ioctl.
Ask yourself: why standard ethernet routine (which is just sample,
your driver may have one which you desire) prohibits to change its address,
when it is UP?
There are two answers:
1. Because hardware may be confused, when reinitializing card in flight.
It does not apply to your case.
2. Because another software (f.e. ARP) will be confused as well.
It applies to your case and, moreover, doing such ioctl privately,
you bypass even those modest checks, which could be made by core.
Please, repair this yet to use standard SIOCSIFHWADDR.
Also, think about multicast filters. Now this driver is functional
only for IP without multicasts, despite of the adverticements. 8)
Alexey
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Wed Mar 15 2000 - 21:00:18 EST