Re: ext3 status?

From: Andreas Dilger (adilger@home.com)
Date: Fri Mar 03 2000 - 11:20:52 EST


Stephen writes:
> Just create it empty and tell ext3 which inode it is in, and it will
> initialise it internally on first mount, yes.

I had a quick look at the ext3 code, and I could not find any sort of
check whether the journal was a "valid" file or not. I would hate to
accidentally give "2" or some other inode as the journal, and then ext3
happily overwrites it. Maybe there should be a check that the first
block (or the whole file) is zero-filled (if it is a new journal) or
that there is a magic number at the start.

If this is already in the code and I missed it, please carry on...

Cheers, Andreas

-- 
Andreas Dilger  \ "If a man ate a pound of pasta and a pound of antipasto,
                 \  would they cancel out, leaving him still hungry?"
http://www-mddsp.enel.ucalgary.ca/People/adilger/               -- Dogbert

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue Mar 07 2000 - 21:00:14 EST