via-rhine: kfree_skb on hard IRQ ... still in 2.3.45

From: Urban Widmark (urban@svenskatest.se)
Date: Mon Feb 14 2000 - 17:49:58 EST


I saw these warnings with .44, but I also saw reports for various cards so
I assumed it was going to get fixed by someone who knows what he is doing.
Failing that ... :)

kfree_skb -> dev_kfree_skb_irq in the interrupt handler (I assume, it
gets rid of the annoying warning message anyway).

kfree_skb -> dev_kfree_skb since I saw someone else make that change ...

/Urban

--- linux-2.3.45-orig/drivers/net/via-rhine.c Mon Feb 14 19:59:46 2000
+++ linux/drivers/net/via-rhine.c Mon Feb 14 20:02:56 2000
@@ -865,7 +865,7 @@
                                 np->stats.tx_packets++;
                         }
                         /* Free the original skb. */
- kfree_skb(np->tx_skbuff[entry]);
+ dev_kfree_skb_irq(np->tx_skbuff[entry]);
                         np->tx_skbuff[entry] = 0;
                 }
                 if (np->tx_full &&
@@ -1147,13 +1147,13 @@
                 np->rx_ring[i].rx_length = 0;
                 np->rx_ring[i].addr = 0xBADF00D0; /* An invalid address. */
                 if (np->rx_skbuff[i]) {
- kfree_skb(np->rx_skbuff[i]);
+ dev_kfree_skb(np->rx_skbuff[i]);
                 }
                 np->rx_skbuff[i] = 0;
         }
         for (i = 0; i < TX_RING_SIZE; i++) {
                 if (np->tx_skbuff[i])
- kfree_skb(np->tx_skbuff[i]);
+ dev_kfree_skb(np->tx_skbuff[i]);
                 np->tx_skbuff[i] = 0;
         }
 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue Feb 15 2000 - 21:00:28 EST