Re: [PATCH] 2.3.41 - use of ! in Config.in's

From: Andrzej Krzysztofowicz (ankry@green.mif.pg.gda.pl)
Date: Mon Jan 31 2000 - 12:20:59 EST


Hi,

> A few straglers were still doing if [ ! "$CONFIG_FOO" = "n" ]
> rather than the more official/sensable if [ "$CONFIG_FOO" != "n" ]
>
> diff -ru linux-orig/drivers/atm/Config.in linux/drivers/atm/Config.in
> --- linux-orig/drivers/atm/Config.in Thu Oct 7 13:17:09 1999
> +++ linux/drivers/atm/Config.in Mon Jan 31 06:43:34 2000
> @@ -8,7 +8,7 @@
> fi
> if [ "$CONFIG_PCI" = "y" ]; then
> tristate 'Efficient Networks ENI155P' CONFIG_ATM_ENI
> - if [ ! "$CONFIG_ATM_ENI" = "n" ]; then
> + if [ "$CONFIG_ATM_ENI" != "n" ]; then
> bool ' Enable extended debugging' CONFIG_ATM_ENI_DEBUG
> bool ' Fine-tune burst settings' CONFIG_ATM_ENI_TUNE_BURST
> if [ "$CONFIG_ATM_ENI_TUNE_BURST" = "y" ]; then
[...]

Really, it does not hurt.
At the moment all three parsers seem to handle
   ! "CONFIG_FOO" = "n"
clauses properly.

-- 
=======================================================================
  Andrzej M. Krzysztofowicz               ankry@mif.pg.gda.pl
  phone (48)(58) 347 14 61
Faculty of Applied Phys. & Math.,   Technical University of Gdansk

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon Jan 31 2000 - 21:00:29 EST