Re: [PATCH] freeing free spin_lock (2.3.33smp)

Manfred Spraul (manfreds@colorfullife.com)
Mon, 20 Dec 1999 19:46:55 +0100

Gmpf. The second stupid bug in the ipc locking codes.
xawtv calls shmat() with an invalid shmid, and this causes an oops.

Linus, the patch below is correct, could you add it to the next
(pre-)kernel?

--
	Manfred


Mathijs Mohlmann wrote:
> 
>         When I display xawtv-3.02 over my LAN to my 2.3.33 smp laptop,
> it killes my X-server, with the following message:
> 
> Here's the patch (against 2.3.33):
> 
> diff -ruN linux-2.3.33.orig/ipc/shm.c linux-2.3.33/ipc/shm.c
> --- linux-2.3.33.orig/ipc/shm.c Sun Dec 19 23:00:24 1999
> +++ linux-2.3.33/ipc/shm.c      Mon Dec 20 15:56:48 1999
> @@ -550,7 +550,7 @@
>         err = -EINVAL;
>         shp = shm_lock(shmid);
>         if(shp == NULL)
> -               goto out_unlock_up;
> +               goto out_up;
> 
>         err = -EACCES;
>         if (ipcperms(&shp->u.shm_perm, flg))
>




-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/