[patch] vfat memleak [Re: Possible 2.2.14pre12 bug: set_blocksize

Andrea Arcangeli (andrea@suse.de)
Sat, 18 Dec 1999 15:24:11 +0100 (CET)


The set_blocksize changes that I did in 2.2.14pre12 shown a vfat memleak.

Here the fix against 2.2.14pre14:

diff -urN 2.2.14pre12/fs/fat/dir.c 2.2.14pre12-set_blocksize-debug/fs/fat/dir.c
--- 2.2.14pre12/fs/fat/dir.c Sun Oct 31 23:31:31 1999
+++ 2.2.14pre12-set_blocksize-debug/fs/fat/dir.c Sat Dec 18 15:06:22 1999
@@ -265,12 +265,12 @@
}

Found:
- fat_brelse(sb, bh);
res = long_slots + 1;
*spos = cpos - sizeof(struct msdos_dir_entry);
*lpos = cpos - res*sizeof(struct msdos_dir_entry);
MSDOS_I(inode)->i_last_pos = cpos;
exit:
+ fat_brelse(sb, bh);
if (unicode) {
free_page((unsigned long) unicode);
}

Alan could you apply to 2.2.14 also this very minor patch that I commented
on the list some day ago? It's against 2.2.14pre14.

ftp://ftp.*.kernel.org/pub/linux/kernel/people/andrea/proposed/v2.2/2.2.14pre14/set_blocksize-1.gz

Andrea

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/