Re: [PATCH] Minor sys_umount fix (changes semantics slightly)

Rogier Wolff (R.E.Wolff@BitWizard.nl)
Wed, 15 Dec 1999 21:24:52 +0100 (MET)


Guest section DW wrote:
> On Wed, Dec 15, 1999 at 12:46:10PM +0000, Malcolm Beattie wrote:
> > Here's a one-letter patch for 2.3.x to sys_umount to allow it to
> > unmount filesystems whose root inode is a symlink.
> >
> > However, this changes umount semantics very slightly: currently, with
> > a 2.2 kernel, if you have a symlink /foo to /some/mountpoint then
> > umount("/foo") will unmount /some/mountpoint but after this patch
> > that will no longer work. If this inconveniences anyone greatly,
> > please scream
>
> Hmm. I think the standards say "If the directory on which a file system
> is to be mounted is a symlink, the fs is mounted on the dir to which
> the symlink refers" - will check later.
>
> Also, think of the very common case where people mount a CDROM
> on /dev/cdrom which is a symlink to /dev/sr0 or /dev/hdc or so.

Huh? That's not the issue. The issue is:

I use:
mount /cdrom
ls /cdrom
umount /cdrom
while:
ls -l /cdrom
lrwxrwxrwx 1 root root 9 Oct 18 20:46 cdrom -> mnt/cdrom

Regards,

Roger.

-- 
** R.E.Wolff@BitWizard.nl ** http://www.BitWizard.nl/ ** +31-15-2137555 **
*-- BitWizard writes Linux device drivers for any device you may have! --*
 "I didn't say it was your fault. I said I was going to blame it on you."

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/