Re: RAID0 performance odditity

Jens Axboe (axboe@image.dk)
Mon, 13 Dec 1999 23:34:21 +0000


--sfyO1m2EN8ZOtJL6
Content-Type: text/plain; charset=us-ascii

On Mon, Dec 13 1999, stephan@a2000.nu wrote:
> Here on my system i still have the ide + smp lockups
> system is running ok when i disable smp
>
> mainbord is an asus p2b-d (With dual p2-450)
> with 2 promise u/66 controllers
> and 6 ibm 25gb disks (in raid0)
>
> (kernel 2.2.14pre12 + raid0145-19990824 + ide.2.2.14-11.19991204)

Alan has a fix for that. Something like this, I assume.

-- 
*  Jens Axboe <axboe@image.dk>
*  Linux CD-ROM Maintainer
*  http://www.kernel.dk

--sfyO1m2EN8ZOtJL6 Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="ide-smp.diff"

--- ide-disk.c~ Mon Dec 13 23:31:59 1999 +++ ide-disk.c Mon Dec 13 23:32:44 1999 @@ -226,8 +226,10 @@ nsect, rq->nr_sectors - nsect); #endif spin_lock_irqsave(&io_request_lock, flags); /* Is this really necessary? */ - if ((rq->nr_sectors -= nsect) <= 0) + if ((rq->nr_sectors -= nsect) <= 0) { + spin_unlock_irqrestore(&io_request, flags); break; + } if ((rq->current_nr_sectors -= nsect) == 0) { if ((rq->bh = rq->bh->b_reqnext) != NULL) { rq->current_nr_sectors = rq->bh->b_size>>9;

--sfyO1m2EN8ZOtJL6--

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/