> >the attached small patch against 2.3.32-pre2 adds all pagecache blocks
> >that have established mappings to the buffer-cache hashlists (and can thus
>
> Your patch is buggy as you forgot to hash the buffers inside the
> block_*write* stuff.
yep, thanks - i missed this because i just went after all the
init_buffer()'s, the block_*write*() functions have to be covered as well.
> I remeber well the argument: the new pagecache will run fsync reducing the
> complexity of an order of magnitude for reaching the metadata with an
> almost always empty buffer hash so no need of per-inode dirty buffer-queue
> as we are just fast enough compared to 2.2.x. [...]
well i believe we want to have an fsync that does not do any lookups. Even
if it does, metadata is always an order less (plus a constant) for a file.
-- mingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/