Re: [PATCH] Serial driver size reducing (2.3.29)

tytso@mit.edu
Fri, 10 Dec 1999 14:57:57 -0500


Date: Mon, 29 Nov 1999 14:46:52 +0000
From: Jeff Garzik <jgarzik@mandrakesoft.com>

Andrey Panin wrote: 2) added #ifdef MODULE around pci_board_inst[]
> array declaration and usage. As I understand it is safe because
> serial driver compiled into the kernel doesn't unregister serial
> devices (except PCMCIA). Also added '__initdata' to pci_boards[]
> declaration (for same reason);

Have you tested this change for both modular and non-modular cases? It
doesn't look right to me...

It works for now because __initdata and __init are no-op's in the
modular case. This does make me a bit nervous, though, since I'm not
sure this is always going to be a fair assumption.

Comments? Are there are any plans to implement __init and __initdata
for modules?

- Ted

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/