Re: Breakage in arch/i386/kernel/time.c

Benjamin C.R. LaHaise (blah@kvack.org)
Fri, 3 Dec 1999 13:41:31 -0500 (EST)


On Fri, 3 Dec 1999, Richard Gooch wrote:

> But do_gettimeofday() doesn't have any explicit asm code. Sure, it
> does locking, but those lock functions shouldn't affect the C code
> it's called from. If there's leakage from the lock functions, that
> should be fixed.

It's not from the lock functions, but from do_fast_gettimeoffset():

register unsigned long eax asm("ax");
register unsigned long edx asm("dx");

The locking functions use eax for passing args in/out when calling the
helper functions if the variable doesn't have a static address.
Unfortunately, gcc 2.7.2 isn't getting the optimization correct
(&time_lock is a constant). Remove the inline from do_fast_gettimeoffset
and it should compile.

-ben

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/