Re: [CFT][PATCH] block_write_*_buffer rewrite

Martin Dalecki (dalecki@cs.net.pl)
Thu, 02 Dec 1999 22:58:15 +0100


I have found the following snipplett in the code:

--- linux-2.3.30-pre3/include/linux/fs.h Tue Nov 30 20:44:54 1999
+++ linux-bird.symlink/include/linux/fs.h Mon Nov 29 17:40:24 1999
@@ -948,6 +948,9 @@
extern int block_write_full_page (struct dentry *, struct page *);
extern int block_write_partial_page (struct file *, struct page *,
unsigned long, unsigned long, const char *);
extern int block_write_cont_page (struct file *, struct page *,
unsigned long, unsigned long, const char *);
+extern int block_write_zero_range(struct dentry *, struct page *,
unsigned, unsigned, unsigned, const char *);
+#define block_write_range(dentry, page, from, len, buf) \
+ block_write_zero_range(dentry, page, from, from, from+len, buf)
extern int block_flushpage(struct inode *, struct page *, unsigned
long);

extern int generic_file_mmap(struct file *, struct vm_area_struct *);

Ehem. The #define looks lazy. Better do the embedding by an __inline__
wrapper function.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/