Re: PATCH [bugfix for pipe(2) system call]

Matti Aarnio (matti.aarnio@sonera.fi)
Wed, 1 Dec 1999 11:20:34 +0200


On Wed, Dec 01, 1999 at 09:02:46AM +0000, David Howells wrote:
> I've produced a patch which should make sure that sys_pipe() checks that the
> memory it has been asked to write into is actually present and writable.
>
> I've put an implementation in for all the platforms that seemed to care
> already. Not all of them do... is this because they don't have the
> copy_*_user() macros?

Looking at the code, SPARCs and Alpha use processor registers to
return the FDs (they have lots of registers to use), while i386
doesn't have that luxury, and most architectures we keep adding
do follow i386 model on things -- even when they have a plenty
of registers, like m68k, and ppc (very least).

> David
> ====================
> +++ linux-2.3.29/arch/arm/kernel/sys_arm.c Tue Nov 30 20:43:46 1999
> +++ linux-2.3.29/arch/i386/kernel/sys_i386.c Tue Nov 30 20:40:45 1999
> +++ linux-2.3.29/arch/m68k/kernel/sys_m68k.c Tue Nov 30 20:43:55 1999
> +++ linux-2.3.29/arch/ppc/kernel/syscalls.c Tue Nov 30 20:43:37 1999
> +++ linux-2.3.29/arch/sh/kernel/sys_sh.c Tue Nov 30 20:43:26 1999

> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.rutgers.edu
> Please read the FAQ at http://www.tux.org/lkml/

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/