Re: [PATCH] i386 rw semaphore + use for mmap_sem

Linus Torvalds (torvalds@transmeta.com)
Mon, 22 Nov 1999 10:50:12 -0800 (PST)

On Mon, 22 Nov 1999, Marcelo Tosatti wrote:
>
> Your code wakes up all writers (if there are any) in read_up.
> Since just one writer will get the lock, i think its more interesting to
> wake one process.

DON'T DO THIS!

We have a perfectly fine "wake_one()" facility in the form of
TASK_EXCLUSIVE, which can handle all the wake-one cases correctly. Don't
add a new wake_up_one() thing for this.

Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/