Re: set_current_state() vs __set_current_state()

Tim Waugh (twaugh@redhat.com)
Wed, 10 Nov 1999 16:57:19 +0000 (GMT)


On Wed, 10 Nov 1999, Andrea Arcangeli wrote:

> @@ -95,7 +95,7 @@
> our interrupt handler called. */
> if (count && no_irq) {
> parport_release (dev);
> - current->state = TASK_INTERRUPTIBLE;
> + set_current_state (TASK_INTERRUPTIBLE);
> schedule_timeout (wait);
> parport_claim_or_block (dev);
> }
>
> This is definitely _safe_ but slower.

Yes, it was a tyop, as was the other instance in that file.

Thanks for spotting it,
Tim.
*/

Index: linux/drivers/parport/ieee1284_ops.c
diff -u linux/drivers/parport/ieee1284_ops.c:1.4 linux/drivers/parport/ieee1284_ops.c:1.5
--- linux/drivers/parport/ieee1284_ops.c:1.4 Mon Nov 8 17:04:56 1999
+++ linux/drivers/parport/ieee1284_ops.c Wed Nov 10 16:56:29 1999
@@ -95,7 +95,7 @@
our interrupt handler called. */
if (count && no_irq) {
parport_release (dev);
- set_current_state (TASK_INTERRUPTIBLE);
+ __set_current_state (TASK_INTERRUPTIBLE);
schedule_timeout (wait);
parport_claim_or_block (dev);
}
@@ -525,7 +525,7 @@
/* Yield the port for a while. */
if (count && dev->port->irq != PARPORT_IRQ_NONE) {
parport_release (dev);
- set_current_state (TASK_INTERRUPTIBLE);
+ __set_current_state (TASK_INTERRUPTIBLE);
schedule_timeout ((HZ + 24) / 25);
parport_claim_or_block (dev);
}

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/