Re: [PATCH] four warnings and a patch

Michael J. Hartwick (hartwick@primeline.net)
Fri, 29 Oct 1999 13:26:50 -0400 (EDT)


On Thu, 28 Oct 1999 kernel@kvack.org wrote:

> On Thu, 28 Oct 1999, Dennis Hou wrote:
>
> > What are you talking about? There is only one line in the patch:
> >
> > - struct ei_device *ei_local = (struct ei_device *) dev->priv;
>
> Which is very broken: it breaks non-x86 architechures that share the
> 8390.c code.

Wouldn't something like:

struct ei_device *ei_local = (struct ei_device *) NULL;
ei_local = (struct ei_device *) dev->priv;

eliminate the warning in all cases?

I am certainly not an expert with C, but since the variable would then
used somewhere other then the definition it should remove the warning
without adding any more preprocessor stuff, and not break the other
architechures.

I am sure I will be corrected if I am wrong. :)

Michael

----------------------------------------------------------------------
Michael J. Hartwick, VE3SLQ hartwick@primeline.net
Prime-Line Communications (519) 396-8300
Kincardine, ON, CA http://www.primeline.net/primeline
For technical support please email support@primeline.net.
----------------------------------------------------------------------

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/