Re: [PATCH] fixes to include/asm-linux/io.h

Ingo Molnar (mingo@chiara.csoma.elte.hu)
Tue, 26 Oct 1999 23:06:03 +0200 (CEST)


On Tue, 26 Oct 1999, Arnaldo Carvalho de Melo wrote:

> Please apply this patch, which fixes isa_read[wl] and isa_write[wl]

oops, what a dumb cut&paste error of mine :*(

> and adds isa_memcpy_fromio and friends, relative to 2.3.24-pre1.

i've intentionally not added these - we should only add function groups
which are truly used, especially when it's a legacy interface anyway.

I believe the prefered driver model for ISA stuff should be symmetric to
the PCI model: you can ioremap() ISA space addresses just fine, ioremap()
just returns a pointer into directly mapped kernel area, iounmap() works
just fine as well, and you can read[bwl]()/write[bwl]()/etc. the resulting
pointer just like in the PCI case. So i think the isa_() functions should
only be used for truly trivial or legacy code.

-- mingo

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/