Re: [patch] __lock_sock race condition in 2.3.18*

kuznet@ms2.inr.ac.ru
Tue, 21 Sep 1999 20:29:07 +0400 (MSK DST)


Hello!

> The real problem I had in fixing this is that tcp_get_info() it's _not_
> buggy and instead it's doing the right thing.

Actually, it was buggy, because locking socket while holding hash lock
is no-no-no.

OK. Actually, you did exactly the thing, which I tried to avoid (new lock)
and, probably, it is better than way which I advocated.
[ I wanted to use normal socket spinlock for this: it is faster,
but results in some aestetical problems. ]

BTW you can kill lhash sleep lock now. rwlock is enough.

Alexey

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/