Re: [linux-tr] SysKonnect driver broken in new kernels?

Alan Cox (alan@lxorguk.ukuu.org.uk)
Sun, 19 Sep 1999 23:10:54 +0100 (BST)


> Nothing in sktr.c has changed since 16Jun1998 (driver v1.01). The version
> in 2.1.123 is exactly the same as the one in 2.3.18.

So its something it doesnt do. Ok now the right question is
"What changed in ibmtr.c over the same sort of period".

Do you know roughly which actual kernel broke sktr ?
>
> The major thing that breaks is sktr_wait(). Replacing it with a udelay()

I fixed that in my tree. It uses udelay short short stops and schedule
for long ones

> I'm not real sure what breaks recieve. I don't know enough about the
> driver layer to see a problem at a glance. Transmit appears to work just
> fine (though pings don't work since it can't recieve the response).

Well netif_rx is supposed to pass a packet up to the higher layers. The
board seems to be claling this. It also sets skb->protocol before hand
which is correct. The only thing I can't see is who sets skb->dev. It might
be adding skb->dev = dev before the netif_rx makes life happy - try it can
you ?

> Does this driver have an active maintainer? Jay is long gone, and the

No.

> Also, would a patch get accepted that renamed the SysKonnect driver to
> something more like 'Generic TMS380'? (The TMS380 chipset is sortof the
> NE2000 of token ring -- for both ISA and PCI cards.)

Interesting. I didnt know that. You have example non syskonnect cards it works
with ?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/