Re: ide_do_drive_cmd() problems

Gadi Oxman (gadio@netvision.net.il)
Mon, 13 Sep 1999 06:52:11 +0300 (IDDT)


On Sun, 12 Sep 1999, Jens Axboe wrote:

> This fixed the problem beatifully! I stressed ide_do_drive_cmd()
> vigorously (4 drives active, ripping audio and playing video
> CD's) for about an hour without a hitch. This still doesn't
> explain why ide_do_drive_cmd_wait() works well too - I haven't
> looked at the code generated, though. So could we just loose
> the save_flags/cli/restore_flags in ide_do_drive_cmd()?

Yes, I believe it should be safe; down() and up() are written to
catch the case in which an up() is being called by an interrupt
while the down() code is running.

Gadi

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/