Re: [patch] touch_buffer in getblk

Chuck Lever (cel@monkey.org)
Fri, 10 Sep 1999 11:56:38 -0400 (EDT)


On Thu, 9 Sep 1999, Andrea Arcangeli wrote:
> Currently we do touch_buffer in brelse instead of in getblk. It make sense
> to mark the page referenced in getblk so we'll less probably enter the
> try_to_free_buffers path. Also it's possible to cleanup the fast-path of
> getblk.
>
> This patch against 2.3.17 will do that:
>
> [ .. patch snipped .. ]

this is a good idea. the touch_buffer in brelse appears to cause lots of
unnecessary reads. i'd provide some benchmark measurements, but i've hit
a bug in fs/proc/array.c which SDET is triggering (patch to follow later
after i test it further).

- Chuck Lever

--
corporate:	<chuckl@netscape.com>
personal:	<chucklever@netscape.net> or <cel@monkey.org>

The Linux Scalability project: http://www.citi.umich.edu/projects/linux-scalability/

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/