Re: Integration of pcnet_cs into drivers/pcmcia

Pavel Machek (pavel@bug.ucw.cz)
Thu, 9 Sep 1999 21:44:49 +0200


Hi!

> > So my wish for 2.4 came true: pcmcia is integrated in kernel. Here is
> > my help: integrating pcnet_cs (and fixing minor bugs I noticed at the
> > point). It works for me and I think it is the right thing.
>
> ...
>
> > #ifdef CONFIG_PCMCIA
> > pcmcia_init(); /* Do this last */
> > +#ifdef CONFIG_PCMCIA_PCNET
> > + init_pcnet_cs();
> > +#endif
> > #endif
>
> Can't the new module init code be used to avoid having to hack up
> main.c for every driver?

pcmcia is initialized _after_ initcall()'s are done, so I suspect it
would not work. There's probably good reason: pcmcia_init() needs to
know what areas are allocated.

> I'd prefer to wait a bit and do all the PCMCIA client drivers in one
> go, after thinking it through, rather than piecemeal.

Integrating it was rather easy... I do not think much thinking is
required. And - bulkmem is already there, is it? ;-). I can not see
anything wrong with one_driver_at_a_time approach.

Pavel

-- 
I'm really pavel@ucw.cz. Look at http://195.113.31.123/~pavel.  Pavel
Hi! I'm a .signature virus! Copy me into your ~/.signature, please!

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/