Re: PATCH: PCI changes for pre-2.3.16-1

Linus Torvalds (torvalds@transmeta.com)
Tue, 31 Aug 1999 10:56:30 -0700 (PDT)


On Tue, 31 Aug 1999, Martin Mares wrote:
> o Distinguish between pci_dev->name (only bus/slot/function, used for
> PCI subsystem initialization messages) and pci_dev->full_name
> (used for resource management stuff).

This is just crap.

You should NOT use bus/slot/fn in the name. For identification purposes,
you can just use the numbers in the "struct pci_dev" thing directly - no
need to try to continually get them into the name, because they are
already available as pure numbers.

Numbers are numbers, and should be of type "int" or similar.

Text is text, and should be of type "char []".

Why do you have this need to mix the two?

Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/