Re: [PATCH] Driver for Toshiba DVD-RAM (SCSI) (kernel 2.2.11)

Gerard Roudier (groudier@club-internet.fr)
Sat, 28 Aug 1999 09:08:14 +0200 (MET DST)


On Fri, 27 Aug 1999, Reed Meyer wrote:

[ ... ]

> @@ -17,6 +17,15 @@
> *
> * Modified by Jirka Hanika geo@ff.cuni.cz to support more
> * scsi disks using eight major numbers.
> + *
> + * Modified by Reed Meyer <rdm@astro.yale.edu> to support the Toshiba
> + * SD-W1101 DVD-RAM (which doesn't like 6-byte commands). Changed the
> + * default I/O to 10-byte commands, with the minor side-effect that
> + * the driver doesn't use the slightly-faster(?) 6-byte commands

The READ6 and WRITE6 commands are deprecated. The READ6 is still specified
as mandatory for block devices for compatibility with old initialisation
code. WRITE6 is specified as optionnal for block devices.

> + * when circumstances allow. I did this so I wouldn't have to write
> + * code specific to the Toshiba DVD-RAM. If you don't like this
> + * approach, flame me. I have no idea whether it makes a substantial
> + * speed improvement by sticking to 6-byte commands.

IMO, the speed improvement, if it exist, should be not more than a single
micro-second with modern hardware, and, as you know, it can only apply
to the first 2GB for 512 bytes sectors. This makes it irrelevant for
modern systems for both these reasons.

> */

[ ... ]

Gérard.

PS: The READ_6/WRITE_6 problem was, in fact, a known problem. :-)
By the way, you may want to provide the complete patch that eradicates
explicit READ6/WRITE6 commands from the kernel in one step.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/