From: Niels Kristian Bech Jensen <nkbj@image.dk>
I didn't see this error. Are you sure pre-patch-2.3.15-3 was applied
correctly?
On Tue, 24 Aug 1999, Chuck Lever wrote:
> i wrote the patch for filemap.c in 2.3.15-pre3...
>
> i don't see how you could have gotten those compile-time errors. are you
> sure the patch applied correctly?
>
> On Mon, 23 Aug 1999, William Stearns wrote:
>
> > Good day, all,
> > My 2.3.15 pre3 wouldn't compile:
> >
> > gcc -D__KERNEL__ -I/usr/src/linux-2.3.15/include -Wall -Wstrict-prototypes
> > -O2 -fomit-frame-pointer -fno-strict-aliasing -pipe -fn
> > o-strength-reduce -DCPU=586 -march=i586 -c -o filemap.o filemap.c
> > filemap.c: In function `filemap_nopage':
> > filemap.c:1408: `error' undeclared (first use in this function)
> > filemap.c:1408: (Each undeclared identifier is reported only once
> > filemap.c:1408: for each function it appears in.)
> > filemap.c:1423: warning: label `no_page' defined but not used
> > filemap.c:1419: warning: label `failure' defined but not used
> >
> > Defining "error" as an int seemed to allow it to compile and it's
> > running now without any visible problems. It applies over 2.3.15-pre3.
Always possible. Here's take 2:
[root@sparrow src]# pwd
/usr/src
[root@sparrow src]# mkdir linux-2.3.15
[root@sparrow src]# rm -f linux
[root@sparrow src]# ln -sf linux-2.3.15 linux
[root@sparrow src]# cat /usr/src/source/kernel/linux-2.3.14.tar.bz2 |
bunzip2 - | tar -xf -
[root@sparrow src]# patch --ignore-whitespace --remove-empty-files -p0
</usr/src/kpatches-23/pre-patch-2.3.15-3
[ lots of successful patches deleted ]
patching file `linux/kernel/sysctl.c'
patching file `linux/kernel/time.c'
patching file `linux/mm/filemap.c'
patching file `linux/mm/filemap.c.orig'
^^^^ [ Huh? ]
patching file `linux/mm/memory.c'
patching file `linux/mm/mlock.c'
[ more successful patches deleted ]
I hadn't noticed this before; I usually use patch -s (silent,
unless errors occur) in my kernel build script. From the patch, it looks
like filemap.c.orig is created from scratch; perhaps it was left over in
Linus' tree when he did the diff.
This is interesting; filemap.c.orig has an "int error" line that
is removed in filemap.c. Could that be relevant?
Cheers,
- Bill
---------------------------------------------------------------------------
FLASH! Intelligence of mankind decreasing!
Details at...uh, when the little hand is on the....
(Courtesy of Joe <jgreen@t-rex.stu.wesleyan.edu>)
--------------------------------------------------------------------------
William Stearns (wstearns@pobox.com). Mason, Buildkernel, named2hosts,
and ipfwadm2ipchains are at: http://www.pobox.com/~wstearns/
--------------------------------------------------------------------------
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/