Re: scsi_reset requirement questions

Doug Ledford (dledford@redhat.com)
Fri, 13 Aug 1999 11:25:01 -0400


Alan Cox wrote:
>
> > what you are implying. The real intent of those two flags is that in the case
> > of 1 above, the command is triggering a reset condition as a result of the
> > return value passed to old_scsi_done() and this reset is being done as part of
> > the command completion processing. This is a hint to the low level driver's
> > reset routine that it shouldn't find the command down there anywhere, but that
>
> Is the io_request lock held for this case since it will be held calling
> old_scsi_done() ? It isnt held for the other cases of reset.

It is held, and it is held in all other cases as well. The other cases all
originate from SCSI timeouts, check the function old_scsi_timesout() and
you'll see we grab the spinlock in there before we call the abort or reset
routines.

-- 
  Doug Ledford   <dledford@redhat.com>
   Opinions expressed are my own, but
      they should be everybody's.

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/