Re: parport_pc patch and question

Michail Brzitwa (mb@ichabod.han.de)
Fri, 13 Aug 1999 11:09:44 +0200


In article <mng==Pine.LNX.3.96.990810175151.24231A-100000@alpha.ifdtung.if.ua> you wrote:
> [...]
> --- parport_pc_old.c Tue Aug 10 09:46:10 1999
> +++ parport_pc.c Tue Aug 10 15:23:03 1999
> @@ -1879,7 +1879,7 @@
> if (p->irq != PARPORT_IRQ_NONE)
> free_irq(p->irq, p);
> release_region(p->base, 3);
> - if (p->size > 3);
> + if (p->size > 3)
> release_region(p->base + 3, p->size - 3);
> if (p->modes & PARPORT_MODE_ECP)
> release_region(p->base_hi, 3);

I just grepped through the 2.3.13 sources and found also

--- drivers/sound/sb_common.c.orig Fri Aug 13 10:50:45 1999
+++ drivers/sound/sb_common.c Fri Aug 13 10:50:55 1999
@@ -897,7 +897,7 @@
}
if (!(devc->caps & SB_NO_AUDIO && devc->caps & SB_NO_MIDI))
{
- if (devc->irq > 0);
+ if (devc->irq > 0)
free_irq(devc->irq, devc);

sound_unload_mixerdev(devc->my_mixerdev);

and

--- drivers/i2o/i2o_core.c.orig Fri Aug 13 10:52:14 1999
+++ drivers/i2o/i2o_core.c Fri Aug 13 10:52:22 1999
@@ -310,7 +310,7 @@

*p=c->next;
spin_unlock(&i2o_configuration_lock);
- if(c->page_frame);
+ if(c->page_frame)
kfree(c->page_frame);
if(c->hrt)
kfree(c->hrt);

The sb_common.c unconditional free_irq also exists in 2.2.

-- 
Michail Brzitwa            <mb@ichabod.han.de>            +49-511-343215

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/