Re: [PATCH 2.2.10] Re: Problem with memmap file with SMP

Linus Torvalds (torvalds@transmeta.com)
Thu, 15 Jul 1999 09:24:24 -0700 (PDT)

On Thu, 15 Jul 1999, Stephen C. Tweedie wrote:
>
> 0 is fine. The case we are trying to detect is an alias between the
> source buffer and the page cache, which is a kernel VA. 0 can never be
> mistaken for a valid kernel address, so it's just fine. Any user
> address would be OK --- it's only with kernel addresses that we'd have
> to be careful.

0 wouldn't be acceptable for 2.3.x, as it CAN be a kernel address on a
number of machines. But as the problem doesn't exist in 2.3.x anyway I
guess that is a non-issue.

It's a singularly ugly fix, regardless. I would never let code like that
near any of my kernels, but Alan is the one who gets to decide in the
stable tree.

Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/