Re: loop.c broken in 2.3.10?

Arvind Sankar (arvinds@mit.edu)
Thu, 8 Jul 1999 22:18:29 -0400


Sorry about that one. Didn't search the archives.

What about this? That should be close_on_exec->fds_bits.

fs/exec.c:
@@ -465,8 +470,7 @@
i = j * __NFDBITS;
if (i >= files->max_fds)
break;
- set = files->close_on_exec.fds_bits[j];
- files->close_on_exec.fds_bits[j] = 0;
+ set = xchg(&files->close_on_exec.fds_bits[j], 0);
j++;
for ( ; set ; i++,set >>= 1) {
if (set & 1)

On Thu, Jul 08, 1999 at 10:08:40PM -0400, Arvind Sankar wrote:
> The following hunk is bad: There is no bmap in inode_operations any more.
> Should that be get_block instead?
>
> --- loop.c 1999/06/02 18:04:00 1.26
> +++ loop.c 1999/07/07 17:33:50 1.28
> @@ -369,6 +375,10 @@
> a file structure */
> lo->lo_backing_file = NULL;
> } else if (S_ISREG(inode->i_mode)) {
> + if (!inode->i_op->bmap) {
> + printk(KERN_ERR "loop: device has no block access/not implemented\n");
> + goto out_putf;
> + }
>
> /* Backed by a regular file - we need to hold onto
> a file structure for this file. We'll use it to
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.rutgers.edu
> Please read the FAQ at http://www.tux.org/lkml/

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/