---559023410-21307229-931242446=:23200
Content-Type: TEXT/PLAIN; CHARSET=US-ASCII
Content-ID: <Pine.LNX.4.10.9907061103562.494@oof.netnation.com>
On Tue, 6 Jul 1999, Simon Kirby wrote:
> On Tue, 6 Jul 1999, Alexander Viro wrote:
> >
> > Right. You do. It's a combination of my idiocy and idiocy of slocate
> > authors. Sigh... In case of root directory the second entry (fake "..")
> > got an d_off (offset of the next entry) equal to 0 *if* there were
> > additional entries successfully filled by getdents(). My idiocy.
> > Now, authors of slocate, in their infinite wisdom, decided to do
> > seekdir after each readdir. Which means that they call getdents (on a
> > decently-sized buffer) for each bloody offset. It is idiocy. Number of
> > getdents() calls is 2 orders of magintude higher than it should be.
> > Combination of those bogosities gave an infinite loop.
> > Fix for FAT attached (it's against -ac8, with 2.2.9 it will get a
> > line numbers offset but will apply fine).
> >
> > As for slocate... Look for seekdir(recdir, telldir()); and shoot
> > it. Dunno if the author reads l-k (he didn't leave an address in the
> > source), but just in case: seekdir() is *NOT* needed if you read
> > sequentially. Just as fseek(); is not needed for files in the similar
> > case.
>
> The author works for NetNation (the same company I work for). I will
> forward this to him.
The author says that the seeks in there were part of his debugging stuff
which he forgot to remove, and that it's all happy in the new version
(email below).
Simon-
| Simon Kirby | Systems Administration |
| mailto:sim@netnation.com | NetNation Communications |
| http://www.netnation.com/ | Tech: (604) 684-6892 |
--- Date: Tue, 6 Jul 1999 09:43:56 -0700 (PDT) From: Kevin Lindsay <klindsay@netnation.com> To: sim@netnation.com Subject: linux-kernel thread
That is strange because that he didn't find my email because it is in the header of all my slocates... :-/
Maybe you could post a message to the list to let everyone know that v2.0 is out in src form, I'm waiting for redhat to get an rpm out on rawhide, and debian should be propogated soon to the debian potato mirrors.
---559023410-21307229-931242446=:23200 Content-Type: TEXT/PLAIN; CHARSET=US-ASCII; NAME=foo Content-Transfer-Encoding: BASE64 Content-ID: <Pine.GSO.4.10.9907060227260.23200@weyl.math.psu.edu> Content-Description: Content-Disposition: ATTACHMENT; FILENAME=foo
LS0tIGZzL2ZhdC9kaXIuYwlUdWUgSnVsICA2IDAxOjQ0OjQ1IDE5OTkNCisr KyBmcy9mYXQvZGlyLmMubmV3CVR1ZSBKdWwgIDYgMDE6NTA6MzAgMTk5OQ0K QEAgLTMxMCw2ICszMTAsOCBAQA0KIAljaGFyIGJ1Zm5hbWVbMTRdOw0KIAlj aGFyICpwdG5hbWUgPSBidWZuYW1lOw0KIAlpbnQgZG90b2Zmc2V0ID0gMDsN CisJdW5zaWduZWQgbG9uZyAqZnVycmZ1ID0gJmxwb3M7DQorCXVuc2lnbmVk IGxvbmcgZHVtbXk7DQogDQogCWNwb3MgPSBmaWxwLT5mX3BvczsNCiAvKiBG YWtlIC4gYW5kIC4uIGZvciB0aGUgcm9vdCBkaXJlY3RvcnkuICovDQpAQCAt MzIwLDggKzMyMiwxMSBAQA0KIAkJCWNwb3MrKzsNCiAJCQlmaWxwLT5mX3Bv cysrOw0KIAkJfQ0KLQkJaWYgKGNwb3MgPT0gMikNCisJCWlmIChjcG9zID09 IDIpIHsNCisJCQlkdW1teSA9IDI7DQorCQkJZnVycmZ1ID0gJmR1bW15Ow0K IAkJCWNwb3MgPSAwOw0KKwkJfQ0KIAl9DQogCWlmIChjcG9zICYgKHNpemVv ZihzdHJ1Y3QgbXNkb3NfZGlyX2VudHJ5KS0xKSkNCiAJCXJldHVybiAtRU5P RU5UOw0KQEAgLTQ1NSw3ICs0NjAsNyBAQA0KIAlpZiAoIWxvbmdfc2xvdHN8 fHNob3J0bmFtZXMpIHsNCiAJCWlmIChib3RoKQ0KIAkJCWJ1Zm5hbWVbaV0g PSAnXDAnOw0KLQkJaWYgKGZpbGxkaXIoZGlyZW50LCBidWZuYW1lLCBpLCBs cG9zLCBpbnVtKSA8IDApDQorCQlpZiAoZmlsbGRpcihkaXJlbnQsIGJ1Zm5h bWUsIGksICpmdXJyZnUsIGludW0pIDwgMCkNCiAJCQlnb3RvIEZpbGxGYWls ZWQ7DQogCX0gZWxzZSB7DQogCQljaGFyIGxvbmduYW1lWzI3NV07DQpAQCAt NDY2LDExICs0NzEsMTIgQEANCiAJCQltZW1jcHkoJmxvbmduYW1lW2xvbmdf bGVuKzFdLCBidWZuYW1lLCBpKTsNCiAJCQlsb25nX2xlbiArPSBpOw0KIAkJ fQ0KLQkJaWYgKGZpbGxkaXIoZGlyZW50LCBsb25nbmFtZSwgbG9uZ19sZW4s IGxwb3MsIGludW0pIDwgMCkNCisJCWlmIChmaWxsZGlyKGRpcmVudCwgbG9u Z25hbWUsIGxvbmdfbGVuLCAqZnVycmZ1LCBpbnVtKSA8IDApDQogCQkJZ290 byBGaWxsRmFpbGVkOw0KIAl9DQogDQogUmVjRW5kOg0KKwlmdXJyZnUgPSAm bHBvczsNCiAJZmlscC0+Zl9wb3MgPSBjcG9zOw0KIAlnb3RvIEdldE5ldzsN CiBFT0RpcjoNCg== ---559023410-21307229-931242446=:23200--
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/