>You may be right. There's a huge race in wakeup_bdflush. If asked to
>wait, it calls run_task_queue(&tq_disk) after waking bdflush but
>BEFORE sleeping on bdflush_done. That's been there for a really long
>time, I guess it is easier to trigger with my changes applied.
You are completly right about this. This is a completly untested fix alone
against 2.2.9 (my buffer code fixed this too but only incidentally, and
that's why I didn't thought too much about your words above until now).
--- linux/fs/buffer.c Fri May 14 20:22:39 1999
+++ linux/fs/buffer.c Mon May 17 03:04:51 1999
@@ -1561,11 +1561,11 @@
{
if (current == bdflush_tsk)
return;
- wake_up(&bdflush_wait);
- if (wait) {
+ if (wait)
run_task_queue(&tq_disk);
+ wake_up(&bdflush_wait);
+ if (wait)
sleep_on(&bdflush_done);
- }
}
Andrea Arcangeli
---I wonder if this patch is helping us at all here? As I haven't seen any ext2 messages at all on any of the machines here, I can't compare, but perhaps people experiencing the problems could add this to their list of things to try as well. :)
Simon-
| Simon Kirby | Systems Administration | | mailto:sim@netnation.com | NetNation Communications | | http://www.netnation.com/ | Tech: (604) 684-6892 |
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/