IDE patch: "DeviceFault" errors

Mark Lord (mlord@pobox.com)
Sun, 02 May 1999 19:58:00 -0400


This is a multi-part message in MIME format.
--------------60D4E4C4A9C58D94C8274131
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

Hi.

Somehow, this functionality got lost (or was never there)
in the IDE driver. I have a drive which never recovers
from problems without this patch. Please apply to whatever
the next release will be.

The patch only kicks in on "DeviceFault" errors (formerly called
the "werr" bit, status 0x20), we already have a mechanism to ignore
this bit in cases where it (already) rarely is misreported ("nowerr").

Cheers

-- 
mlord@pobox.com
--------------60D4E4C4A9C58D94C8274131
Content-Type: text/plain; charset=us-ascii;
 name="ide-2.2.7.pat1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="ide-2.2.7.pat1"

--- linux-2.2.7/drivers/block/ide.c.227 Tue Mar 23 19:28:21 1999 +++ linux/drivers/block/ide.c Fri Apr 30 09:25:23 1999 @@ -813,7 +813,7 @@ ide_end_drive_cmd(drive, stat, err); return; } - if (stat & BUSY_STAT) { /* other bits are useless when BUSY */ + if (stat & BUSY_STAT || ((stat & WRERR_STAT) && !drive->nowerr)) { /* other bits are useless when BUSY */ rq->errors |= ERROR_RESET; } else { if (drive->media == ide_disk && (stat & ERR_STAT)) {

--------------60D4E4C4A9C58D94C8274131--

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/